DATAOPS-779: Fix undetermined percentage handler #117
Conversation
There was a problem hiding this comment.
Looks good! On top of the other comment, I think it would be nice if the results of the CI were shown in pull requests. I think this can be done by changing the following line in the ci file: on: [push, pull_request].
It might not work for this PR but I think it should for all the PRs that will be created after that.
Ah yes, I agree. Will fix! |
|
Thanks for the comments! Using a dict made it so much cleaner 👌 |
This PR fixes an issue where the Undetermined handler did not report any errors. This issue was introduced when we updated the interop parser to return info about index reads. PhiX for index reads are NaN and the handler did not handle this properly.
One reason that we missed this bug, was that the interop parser was tested with a MiSeq without index reads. I have now added a new public dataset with index reads and updated the tests accordingly.
Validation procedure: I ran this version on a runfolder where too high % determined had been reported. % Undetermined errors were displayed as expected. I don't think any further manual testing is required.