feat: ✨ Apply Forest root changes to Buckets in Blockchain Service #335
Conversation
…elete_file` tasks
…own the bucket ID
| @@ -484,10 +484,14 @@ pub mod pallet { | |||
| /// This is the generic version of [`MutationsAppliedForProvider`](Event::MutationsAppliedForProvider) | |||
| /// when [`generic_apply_delta`](ProofsDealerInterface::generic_apply_delta) is used | |||
| /// and the root is not necessarily linked to a specific Provider. | |||
| /// | |||
| /// Additional information for context on where the mutations were applied can be provided | |||
| /// by using the `event_info` field. | |||
There was a problem hiding this comment.
I would point to the common encode and decode functions if you agree to add them
There was a problem hiding this comment.
I won't include that encoding/decoding function and runtime API here in the ProofsDealer pallet. This pallet is abstracted over what other pallets might want to send as event_info. It should be in the FileSystem pallet IMO.
|
I noticed there are no integration tests added to the reorg. Was this planned for a separate PR? |
Yes. I gave it less urgency as "handling the reorgs" is essentially already tested with the BSP tests. It is the same functionality. But the right thing to do would be also to have tests for the MSPs. We'll just do it in a different PR, to prioritise other issues and tasks. Thanks for bringing this up though! |
This PR depends on #312.
In this PR:
MutationsAppliedevent inapply_forest_root_changesof the Blockchain Service, to apply forest root changes of MSPs.insert_files_metadatacall frommsp_upload_file, now that this is done in the Blockchain Service.query_buckets_for_mspnew runtime API to Providers pallet.event_infotogeneric_apply_deltafunction fromProofsDealerInterface. The intention is that users of this interface can pass aVec<u8>of encoded info for context on what the delta is applied on. For the purpose of this PR, that is used for the File System pallet to pass down the encoded Bucket ID.