Feat: msp move bucket stop storing #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snowmead
approved these changes
Feb 19, 2025
… import and finality notification
ffarall
requested changes
Feb 26, 2025
Comment on lines
1451
to
1457
| if old_msp_id == Some(own_msp_id) { | ||
| // We are the old MSP, emit event to clean up | ||
| self.emit(BucketMovedAway { | ||
| bucket_id, | ||
| old_msp_id: own_msp_id, | ||
| new_msp_id: new_msp_id, | ||
| }); |
There was a problem hiding this comment.
Shouldn't this be emitted in finality?
node/src/tasks/msp_delete_bucket.rs
Outdated
Comment on lines
61
to
81
| async fn delete_bucket(&mut self, bucket_id: &BucketId) -> anyhow::Result<()> { | ||
| self.storage_hub_handler | ||
| .file_storage | ||
| .write() | ||
| .await | ||
| .delete_files_with_prefix( | ||
| &bucket_id | ||
| .as_ref() | ||
| .try_into() | ||
| .map_err(|_| anyhow!("Invalid bucket id"))?, | ||
| ) | ||
| .map_err(|e| anyhow!("Failed to delete files with prefix: {:?}", e))?; | ||
|
|
||
| self.storage_hub_handler | ||
| .forest_storage_handler | ||
| .remove_forest_storage(&bucket_id.as_ref().to_vec()) | ||
| .await; | ||
|
|
||
| Ok(()) | ||
| } | ||
| } |
ffarall
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is built on top of #373.
This fixes issue 35.