Merge pull request #65 from Mozilla-Ocho/bug/pdf-page-name

Fix the generated filename for pdfs
Mozilla-Ocho · Mar 7, 2024 · 4ee8e93 · 4ee8e93
2 parents 775105c + 6644032
commit 4ee8e93
Showing 1 changed file with 11 additions and 2 deletions.
diff --git a/extension/popup/memory_cache.js b/extension/popup/memory_cache.js
@@ -16,7 +16,16 @@ async function generateFileName(ext) {
       }
     })
     .then ((fileName)=> {
-      return fileName.replaceAll(":","");
+      return fileName.replaceAll(":","")
+                     .replaceAll("!","")
+                      .replaceAll("?","")
+                      .replaceAll("/","")
+                      .replaceAll("\\","")
+                      .replaceAll("*","")
+                      .replaceAll("|","")
+                      .replaceAll(" ","")
+                      .replaceAll("<","")
+                      .replaceAll(">","");
     })
     .catch((error) => {
       reject(`Error querying tabs: ${error}`);
@@ -34,7 +43,7 @@ async function savePDF() {
     // Fallback to non-silent mode.
     await browser.tabs.saveAsPDF({
       // Omit the DOWNLOAD_SUBDIRECTORY prefix because saveAsPDF will not respect it.
-      toFileName: `PAGE-${generateFileName("pdf")}`,
+      toFileName: `PAGE-${await generateFileName("pdf")}`,
     });
   }
 }