Skip to content

Refactor messaging to not need custom CommandIssuer implementation. #376

Refactor messaging to not need custom CommandIssuer implementation.

Refactor messaging to not need custom CommandIssuer implementation. #376

Triggered via pull request January 27, 2025 20:48
Status Success
Total duration 28s
Artifacts

pr.checkstyle.yml

on: pull_request
checkstyle  /  checkstyle
19s
checkstyle / checkstyle
Fit to window
Zoom out
Zoom in

Annotations

1 error and 11 warnings
checkstyle / checkstyle
reviewdog: Too many results (annotations) in diff. You may miss some annotations due to GitHub limitation for annotation created by logging command. Please check GitHub Actions log console to see all results. Limitation: - 10 warning annotations and 10 error annotations per step - 50 annotations per job (sum of annotations from all the steps) - 50 annotations per run (separate from the job annotations, these annotations aren't created by users) Source: https://github.community/t5/GitHub-Actions/Maximum-number-of-annotations-that-can-be-created-using-GitHub/m-p/39085
checkstyle / checkstyle
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
checkstyle / checkstyle: src/main/java/org/mvplugins/multiverse/core/commandtools/queue/CommandQueueManager.java#L16
[checkstyle] reported by reviewdog 🐶 Extra separation in import group before 'co.aikar.commands.CommandIssuer' Raw Output: /github/workspace/./src/main/java/org/mvplugins/multiverse/core/commandtools/queue/CommandQueueManager.java:16:1: warning: Extra separation in import group before 'co.aikar.commands.CommandIssuer' (com.puppycrawl.tools.checkstyle.checks.imports.ImportOrderCheck)
checkstyle / checkstyle: src/main/java/org/mvplugins/multiverse/core/commandtools/queue/CommandQueueManager.java#L16
[checkstyle] reported by reviewdog 🐶 Wrong order for 'co.aikar.commands.CommandIssuer' import. Raw Output: /github/workspace/./src/main/java/org/mvplugins/multiverse/core/commandtools/queue/CommandQueueManager.java:16:1: warning: Wrong order for 'co.aikar.commands.CommandIssuer' import. (com.puppycrawl.tools.checkstyle.checks.imports.ImportOrderCheck)
checkstyle / checkstyle: src/main/java/org/mvplugins/multiverse/core/commandtools/queue/CommandQueueManager.java#L137
[checkstyle] reported by reviewdog 🐶 Return count is 3 (max allowed for non-void methods/lambdas is 2). Raw Output: /github/workspace/./src/main/java/org/mvplugins/multiverse/core/commandtools/queue/CommandQueueManager.java:137:5: info: Return count is 3 (max allowed for non-void methods/lambdas is 2). (com.puppycrawl.tools.checkstyle.checks.coding.ReturnCountCheck)
checkstyle / checkstyle: src/main/java/org/mvplugins/multiverse/core/commandtools/queue/CommandQueueManager.java#L137
[checkstyle] reported by reviewdog 🐶 Expected @param tag for 'otp'. Raw Output: /github/workspace/./src/main/java/org/mvplugins/multiverse/core/commandtools/queue/CommandQueueManager.java:137:72: warning: Expected @param tag for 'otp'. (com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck)
checkstyle / checkstyle: src/main/java/org/mvplugins/multiverse/core/commandtools/queue/CommandQueueManager.java#L170
[checkstyle] reported by reviewdog 🐶 Return count is 3 (max allowed for non-void methods/lambdas is 2). Raw Output: /github/workspace/./src/main/java/org/mvplugins/multiverse/core/commandtools/queue/CommandQueueManager.java:170:5: info: Return count is 3 (max allowed for non-void methods/lambdas is 2). (com.puppycrawl.tools.checkstyle.checks.coding.ReturnCountCheck)
checkstyle / checkstyle: src/main/java/org/mvplugins/multiverse/core/commandtools/queue/CommandQueuePayload.java#L15
[checkstyle] reported by reviewdog 🐶 Type Javadoc comment is missing @param <T> tag. Raw Output: /github/workspace/./src/main/java/org/mvplugins/multiverse/core/commandtools/queue/CommandQueuePayload.java:15:1: warning: Type Javadoc comment is missing @param <T> tag. (com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocTypeCheck)
checkstyle / checkstyle: src/main/java/org/mvplugins/multiverse/core/commandtools/queue/CommandQueuePayload.java#L23
[checkstyle] reported by reviewdog 🐶 Expected @param tag for '<T>'. Raw Output: /github/workspace/./src/main/java/org/mvplugins/multiverse/core/commandtools/queue/CommandQueuePayload.java:23:20: warning: Expected @param tag for '<T>'. (com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck)
checkstyle / checkstyle: src/main/java/org/mvplugins/multiverse/core/commandtools/MVCommandManager.java#L138
[checkstyle] reported by reviewdog 🐶 Class 'MVCommandManager' looks like designed for extension (can be subclassed), but the method 'getConsoleCommandIssuer' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MVCommandManager' final or making the method 'getConsoleCommandIssuer' static/final/abstract/empty, or adding allowed annotation for the method. Raw Output: /github/workspace/./src/main/java/org/mvplugins/multiverse/core/commandtools/MVCommandManager.java:138:5: info: Class 'MVCommandManager' looks like designed for extension (can be subclassed), but the method 'getConsoleCommandIssuer' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MVCommandManager' final or making the method 'getConsoleCommandIssuer' static/final/abstract/empty, or adding allowed annotation for the method. (com.puppycrawl.tools.checkstyle.checks.design.DesignForExtensionCheck)
checkstyle / checkstyle: src/main/java/org/mvplugins/multiverse/core/commands/TeleportCommand.java#L124
[checkstyle] reported by reviewdog 🐶 Return count is 2 (max allowed for void methods/constructors/lambdas is 1). Raw Output: /github/workspace/./src/main/java/org/mvplugins/multiverse/core/commands/TeleportCommand.java:124:5: info: Return count is 2 (max allowed for void methods/constructors/lambdas is 1). (com.puppycrawl.tools.checkstyle.checks.coding.ReturnCountCheck)
checkstyle / checkstyle: src/main/java/org/mvplugins/multiverse/core/commands/TeleportCommand.java#L124
[checkstyle] reported by reviewdog 🐶 Cyclomatic Complexity is 12 (max allowed is 7). Raw Output: /github/workspace/./src/main/java/org/mvplugins/multiverse/core/commands/TeleportCommand.java:124:5: warning: Cyclomatic Complexity is 12 (max allowed is 7). (com.puppycrawl.tools.checkstyle.checks.metrics.CyclomaticComplexityCheck)