Skip to content

Commit

Permalink
Use ACFUtil for random instance
Browse files Browse the repository at this point in the history
  • Loading branch information
benwoo1110 committed Jan 24, 2025
1 parent d3274cc commit 8096a4e
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import java.util.Collections;
import java.util.Random;

import co.aikar.commands.ACFUtil;
import co.aikar.commands.annotation.CommandAlias;
import co.aikar.commands.annotation.CommandCompletion;
import co.aikar.commands.annotation.CommandPermission;
Expand Down Expand Up @@ -41,11 +42,9 @@ final class CreateCommand extends CoreCommand {
private final WorldManager worldManager;
private GeneratorProvider generatorProvider;

private final Random random = new Random();

private final CommandValueFlag<String> seedFlag = flag(CommandValueFlag.builder("--seed", String.class)
.addAlias("-s")
.completion(input -> Collections.singleton(String.valueOf(random.nextLong())))
.completion(input -> Collections.singleton(String.valueOf(ACFUtil.RANDOM.nextLong())))
.build());

private final CommandValueFlag<String> generatorFlag = flag(CommandValueFlag
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

import java.util.Collections;
import java.util.List;
import java.util.Random;

import co.aikar.commands.ACFUtil;
import co.aikar.commands.annotation.CommandAlias;
import co.aikar.commands.annotation.CommandCompletion;
import co.aikar.commands.annotation.CommandPermission;
Expand Down Expand Up @@ -41,11 +41,9 @@ final class RegenCommand extends CoreCommand {
private final PlayerWorldTeleporter playerWorldTeleporter;
private final WorldTickDeferrer worldTickDeferrer;

private final Random random = new Random();

private final CommandValueFlag<String> seedFlag = flag(CommandValueFlag.builder("--seed", String.class)
.addAlias("-s")
.completion(input -> Collections.singleton(String.valueOf(random.nextLong())))
.completion(input -> Collections.singleton(String.valueOf(ACFUtil.RANDOM.nextLong())))
.optional()
.build());

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import java.util.Random;

import co.aikar.commands.ACFUtil;
import org.bukkit.World;
import org.bukkit.WorldType;
import org.bukkit.block.Biome;
Expand Down Expand Up @@ -39,7 +40,7 @@ public final class CreateWorldOptions {
*/
CreateWorldOptions(@NotNull String worldName) {
this.worldName = worldName;
this.seed = (new Random()).nextLong();
this.seed = ACFUtil.RANDOM.nextLong();
}

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import java.util.Random;

import co.aikar.commands.ACFUtil;
import org.bukkit.block.Biome;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable;
Expand All @@ -23,8 +24,6 @@ public final class RegenWorldOptions implements KeepWorldSettingsOptions {
return new RegenWorldOptions(world);
}

private final Random random = new Random();

private final LoadedMultiverseWorld world;
private Biome biome;
private boolean keepGameRule = true;
Expand Down Expand Up @@ -197,7 +196,7 @@ public boolean randomSeed() {
*/
public long seed() {
if (randomSeed) {
return random.nextLong();
return ACFUtil.RANDOM.nextLong();
} else if (seed == Long.MIN_VALUE) {
return world.getSeed();
}
Expand Down

0 comments on commit 8096a4e

Please sign in to comment.