[move][move-compiler][errors] Add error codes to clever errors #21426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgswords
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
cgswords
requested review from
amnn,
wlmyng,
stefan-mysten and
emmazzz
as code owners
cgswords
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
tzakian
reviewed
Mar 12, 2025
| // Copyright (c) The Move Contributors | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| const BITSET_VALUE_UNAVAILABLE: u16 = u16::MAX; |
There was a problem hiding this comment.
Maybe I'm not grokking, but I'm confused why we need to keep this around, and why we can't just use the new bitset logic in error_bitset.rs?
| pub mod files; | ||
| pub mod interactive; | ||
| pub(crate) mod legacy_error_bitset; |
There was a problem hiding this comment.
If a code for the error is set the behavior can diverge, but otherwise it should be the same between the two no? In which case we should be able to get rid of legacy_error_bitset entirely
external-crates/move/crates/move-compiler/src/typing/translate.rs
Outdated
Show resolved
Hide resolved
external-crates/move/crates/move-compiler/src/typing/translate.rs
Outdated
Show resolved
Hide resolved
external-crates/move/crates/move-compiler/src/typing/translate.rs
Outdated
Show resolved
Hide resolved
7 tasks
tzakian
approved these changes
Mar 19, 2025
Co-authored-by: Tim Zakian <2895723+tzakian@users.noreply.github.com>
cgswords
force-pushed
the
cgswords/clever_error_constants
branch
from
655d187 to
7311d2d
Compare
cgswords
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
cgswords
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
cgswords
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This revises clever errors to include an error code, plus swaps them to
packed_struct.Test plan
Tests versus legacy error codes, updated error code sin transational tests, and additional testing in the sui crate.
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.