rpc benchmark easy: custom file path as log dest. #21533
+10
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
gegaowp
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
amnn
approved these changes
Mar 24, 2025
| @@ -220,8 +220,15 @@ async fn run() -> Result<(), Box<dyn Error>> { | |||
| info!("Found {} logs for method: {}", count, method); | |||
| } | |||
|
|
|||
| // Write logs to file in ascending timestamp order | |||
| let file = File::create("sampled_read_requests.jsonl")?; | |||
| let file_path = env::var("FILE_PATH").unwrap_or_else(|_| ".".to_string()); | |||
There was a problem hiding this comment.
nit: FILE_PATH is quite a generic name for this environment variable -- what about OUTPUT_DIR or something?
It may also be worth considering using clap for argument parsing now -- you have quite a few arguments to this binary now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
title
Test plan
local run of the pull script
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.