Add histogram for max object costs #21535
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
mystenmark
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
mystenmark
force-pushed
the
mlogan-congestion-control-metrics
branch
from
a1f4b2b to
133d76a
Compare
mystenmark
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
| authority_metrics | ||
| .consensus_handler_max_object_costs | ||
| .with_label_values(&["regular_commit"]) | ||
| .set(shared_object_congestion_tracker.max_cost() as i64); | ||
| .observe(max_cost_us as f64 / 1_000.0); |
There was a problem hiding this comment.
I'd leave this unmodifed and fix the buckets, because the "/1000" scalar makes no sense for modes that are not ExecutionTimeEstimate. Then we can adjust units as needed in grafana
(For that matter, the "_us" in the variable names above is incorrect because the commit handler is agnostic as to congestion control units.)
There was a problem hiding this comment.
Sure, I don't mind, but aren't we going to delete the old modes anyway? And we don't really care about this metric for the older ones.
There was a problem hiding this comment.
I can see that argument. If you really want to make it specific to this mode I think it should be f64 seconds to match the convention for the other time-based histogram metrics (latency etc) - but nbd
mystenmark
force-pushed
the
mlogan-congestion-control-metrics
branch
from
133d76a to
3138c41
Compare
mystenmark
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
No description provided.