[fastpath] propose blocks with transaction votes #21564
Open
+377
−105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
mwtian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
mwtian
force-pushed
the
tmw/propose-vote
branch
from
41c4eab to
6ff719d
Compare
mwtian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
arun-koshy
reviewed
Mar 22, 2025
mwtian
force-pushed
the
tmw/propose-vote
branch
from
6ff719d to
b404fbb
Compare
mwtian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
arun-koshy
approved these changes
Mar 24, 2025
| /// Returns the list of blocks that are newly linked. | ||
| /// The returned blocks are guaranteed to be above the GC round. | ||
| /// NOTE: this function should only be called with GC enabled. | ||
| pub(crate) fn recursive_hard_link(&mut self, root_block: BlockRef) -> Vec<BlockRef> { |
There was a problem hiding this comment.
can you add a unit test for this in dag state, unless you think its thoroughly tested elsewhere
| /// A transaction is certified if a quorum of authorities voted to accept it. A block is certified | ||
| /// if every transaction in the block is either certified or rejected. TransactionCertifier outputs | ||
| /// blocks certified in the causal history own proposed blocks. | ||
| /// A transaction is certified if a quorum of authorities in the causal history of a proposed block |
There was a problem hiding this comment.
Thanks for the very clear comment! 😄
| }) | ||
| .collect::<Vec<_>>(); | ||
| let certified_blocks = certifier_state.add_voted_blocks(voted_blocks); | ||
| self.send_certified_blocks(certified_blocks); |
There was a problem hiding this comment.
This could actually end up sending duplicated certified blocks after recovery, correct? Not an issue, probably just have to dedupe on the Sui side.
i.e. Block A1 containing just Tx1 is rejected and certifed via fastpath but not yet proposed so it will get sent to Sui but after the node goes down and recovers it will resend this certified block to Sui?
There was a problem hiding this comment.
Yes similar to consensus commits, sending previously executed transactions is possible and ok.
mwtian
force-pushed
the
tmw/propose-vote
branch
from
b404fbb to
5700ac6
Compare
mwtian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test plan
CI
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.