Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 handle broken backslash path bug on windows #455

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Shuliyey
Copy link

@Shuliyey Shuliyey commented Mar 24, 2025

change

  • change backslash \ to / on new_path function

Background

walrus-site can't render \ url as browser (e.g chrome) auto convert url path \ to /, on windows site-builder will upload object as \ when interacting with walrus-sites move contract, therefore the object path will be inserted as \

Solution

replace \ with / in object path, before writing object to Walrus

References

related to https://discord.com/channels/946098997637042178/1268610159064780973/1352827924260196393

image

when this happens, object with more than one path \ won't render on walrus.site

e.g https://discord.com/channels/946098997637042178/1268610159064780973/1353012825592959129

image

Signed-off-by: Lao Ye <zib0dts9@duck.com>
Copy link

vercel bot commented Mar 24, 2025

@Shuliyey is attempting to deploy a commit to the Mysten Labs Team on Vercel.

A member of the Team first needs to authorize it.

@Tzal3x Tzal3x added bug Something isn't working site-builder labels Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants