Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving documentation to ReadTheDocs #438

Merged
merged 26 commits into from
Apr 3, 2024

Conversation

mkavulich
Copy link
Collaborator

This PR removes the old, LaTeX-based users guide in favor of RST files that are buildable with Sphinx. These new docs have been configured to automatically build with each commit to main on ReadTheDocs, and can be viewed here: html | PDF

For limitations in the new docs compared to the previous LaTeX/PDF, see this comment

NOTE: The original LaTeX files were auto-converted from .tex to .rst using the pandoc utility, and then manually updated for format. The conversion was not perfect: in particular, most section/chapter links were broken, and all code-case text was omitted from the converted docs. These problems needed to be fixed manually, but it's entirely possible some of these may have slipped into the final product.

Resolves #418

@mkavulich mkavulich added work in progress CCPP v7 Needed for CCPP v7 public release labels Mar 14, 2024
@scrasmussen
Copy link
Member

@mkavulich this looks really great! I checked out the branch to add documentation for the single precision build and it was easy to use and worked well. A few comments:

  • with the move away from LaTeX it seems the Makefile should be updated or deleted?
  • I don't know if would be helpful if there was a small section in the documentation to tell users how to build the readthedocs locally or if it should be a README.md under scm/doc/TechGuide? Apologies if this information is already in the docs somewhere. I installed the requirements and then ended up googling the command $ sphinx-build -M html [source_dir] [output_dir]
  • should the chap_function.rst file be named chap_algorithm.rst since it is the Algorithm chapter?

Anyway, these are just small things, overall it worked very well for me!

@mkavulich
Copy link
Collaborator Author

@scrasmussen Thanks for the review! I have updated the Makefile, though I am unable to test the latex/pdf rule because I can not install latexmk on my machine (which is part of why this whole conversation of moving to ReadTheDocs started!). I also added a README.md file to assist people who are interested in building the HTML or PDF documentation.

With regards to renaming documents/chapters, I kept the names from the original .tex files. I would rather keep the format-transition commits contained here and make any other cleanup in subsequent PRs.

Copy link
Member

@scrasmussen scrasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything builds and looks good!

Copy link
Collaborator

@hertneky hertneky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - just a handful of things I noticed in terms of formatting.

Copy link
Collaborator Author

@mkavulich mkavulich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hertneky Thank you for your thorough review! I believe I have addressed all of your comments.

Copy link
Collaborator

@hertneky hertneky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. Thanks Mike

@mkavulich mkavulich merged commit be44954 into NCAR:main Apr 3, 2024
17 checks passed
@grantfirl
Copy link
Collaborator

I didn't review in detail, although, in general, it looks great. Although I love LaTeX, this is a better way to format software docs in pretty much every way. Thanks for doing this.

mzhangw added a commit to mzhangw/ccpp-scm that referenced this pull request May 22, 2024
* upstream/main:
  Add GP SDFs/NMLs to SCM
  minor fix/cleanup
  Add namelist option and sigmab (tracer) for HR3
  add SCM_RRFS_v1 SDF, nml, tracer file; update suite_info; update scm_type_defs to recgonize new tracers
  add script to download and stage climatological aerosol data and fix typo in HR3 namelist
  merge in changes from NCAR#428 from @hertneky
  add CITATION.cff file from @scrasmussen from NCAR#458
  merge changes from @hertneky in NCAR#446
  add HR3 suite and physics namelist from NCAR#445 from @bluefinweiwei
  changes from @bluefinweiwei for PR#419
  Revert submodules
  Update physics
  Address reviewers comments
  update ccpp/physics submodule pointer
  Moving documentation to ReadTheDocs (NCAR#438)
  Synced physics
  update ccpp/physics submodule
  update ccpp/framework
  update CCPP_typedefs to work with PR#181
  update ccpp/physics and .gitmodules
  Added step to skip gridpoint in ensemble if error during case generation
  Added utility script to create input file containing replay points
  Omission from previous commit
  Add capability to use input file with longitude and latitude lists
  update ccpp/physics submodule
  update .gitmodules for whitespace change removal
  update ccpp/physics and .gitmodules
  update ccpp/physics and .gitmodules
  update ccpp/physics submodule pointer
  point .gitmodules back to my branch for CI testing
  update ccpp/physics and .gitmodules
  update ccpp/physics and .gitmodules
  update ccpp/physics and .gitmodules
  Cleanup/Housekeeping. Remove unnecessary interpolation step
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Revert change to CMakeLists
  Revert change to CMakeLists
  Revert change to CMakeLists
  Revert change to CMakeLists
  Update CI
  Update CI
  Add file for Nvidia RTS
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update cmakelists
  Updated CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CMakeLists for Nvidia support
  Update CMakeLists for Nvidia support
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Update CI
  Foundatio for Nvidia CI script
  Synced physics
  Small cahnge from physics needed for replay
  Replay with RUC and NoahMP LSM working
  Some changes for Man to test
  If using model initial conditions and forcing from the UFS (e.g. Replay mode) with an active LSM, the SCM performs a cold-start initialization for the LSM. That is, UFS replay mode currently support cases generated from UFS Restart files (e.g spun up (warm) LSM parameters)
  update ccpp/physics and revert .gitmodules
  update ccpp/physics submodule and revert .gitmodules
  changes to work with ufs/dev PR#155
  update for ufs/dev PR#94
  update ccpp/physics and .gitmodules
  update ccpp/physics and .gitmodules after testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCPP v7 Needed for CCPP v7 public release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert users guide to utilize ReadTheDocs
5 participants