Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Predict scripts support batch size >= 1 #142

Merged
merged 18 commits into from
Jan 23, 2025
Merged

Predict scripts support batch size >= 1 #142

merged 18 commits into from
Jan 23, 2025

Conversation

jsschreck
Copy link
Collaborator

Both rollout_to_netcdf and rollout_metrics should now support batch size >= 1. A config option batch_size was added to example-v2025.2.0.yml.

The metrics scripts will also support calculation of ACC anamoly scores by supplying a climatology file. In the new yaml, this is specified by predict: climatology: '/glade/campaign/cisl/aiml/ksha/CREDIT_arXiv/VERIF/verif_6h/ERA5_clim/ERA5_clim_1990_2019_6h_interp.nc'

Finally, a new script, rollout_ensemble.py has been added which should create an ensemble using bred vectors.

@jsschreck jsschreck changed the title Predict scripts with a batch size Predict scripts support batch size >= 1 Jan 6, 2025
Copy link
Collaborator

@djgagne djgagne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the new predict scripts, especially adding ensemble support and fixing the metrics. I have requested some changes for modularity purposes.

applications/rollout_ensemble.py Show resolved Hide resolved
applications/rollout_ensemble.py Outdated Show resolved Hide resolved
credit/metrics.py Outdated Show resolved Hide resolved
credit/metrics.py Outdated Show resolved Hide resolved
credit/metrics.py Outdated Show resolved Hide resolved
credit/metrics.py Outdated Show resolved Hide resolved
@jsschreck jsschreck requested a review from dkimpara January 23, 2025 16:51
Copy link
Collaborator

@dkimpara dkimpara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modularized code and resolved DJs comments

@jsschreck jsschreck merged commit b5b4ac6 into main Jan 23, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants