Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix on the original multi-step dataset #146

Merged
merged 6 commits into from
Jan 9, 2025
Merged

Bug fix on the original multi-step dataset #146

merged 6 commits into from
Jan 9, 2025

Conversation

jsschreck
Copy link
Collaborator

No description provided.

@jsschreck jsschreck requested a review from kanz76 January 8, 2025 21:52
kanz76
kanz76 approved these changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@kanz76 kanz76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ERA5_and_Forcing_MultiStep with trainerERA5-multistep_grad_accum.py, all looks good!

@jsschreck jsschreck merged commit 85d6810 into main Jan 9, 2025
1 check passed
@jsschreck jsschreck deleted the multistep_bugs branch January 9, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanz76 kanz76 kanz76 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsschreck @kanz76