Merge pull request #238 from NCAS-CMS/fix_tests

Pin `zarr<3`

.github/workflows/test_s3_minio.yml

@@ -80,8 +80,9 @@ jobs:
         run: tests/s3_exploratory/minio_scripts/minio-stop
         if: always()
       - name: Upload HTML report artifact
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: html-report
           path: test-reports/
+          overwrite: true
         if: always()

.github/workflows/test_s3_remote_reductionist.yml

@@ -60,8 +60,9 @@ jobs:
         run: |
           pytest tests/test_compression_remote_reductionist.py
       - name: Upload HTML report artifact
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: html-report
           path: test-reports/
+          overwrite: true
         if: always()

environment.yml

@@ -19,7 +19,7 @@ dependencies:
   - s3fs >=2024.2.0  # loose s3fs deps leading to old aiobotocore for <2024.2.0
   # pin Zarr to avoid using old KVStore interface
   # see github.com/zarr-developers/zarr-python/issues/1362
-  - zarr >=2.13.6  # KVStore to FSStore
+  - zarr >=2.13.6,<3  # KVStore to FSStore, zarr=3 massive refactoring
   # Python packages for testing
   - moto  # mock S3 tests
   - pytest

setup.py

@@ -29,7 +29,8 @@
         'requests',
         's3fs>=2024.2.0',  # see environment.yml for pin reason
         # pin Zarr to use new FSStore instead of KVStore
-        'zarr>=2.13.3', # github.com/zarr-developers/zarr-python/issues/1362
+        # also pin to avoid massive refactoring with zarr>=3
+        'zarr>=2.13.3,<3', # gh/zarr-developers/zarr-python/issues/1362
         # for testing
         'moto',  # mock S3 tests
         'pytest',