'n' component needs to be a numpy array with retained dimensions
#174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
many thanks @davidhassell - this was a bug that I meant to fix for ages now 🐛 🍻 Don't worry about the S3 tests, they conked up since last night, virtually hours after your PR, I suspect it's the new botocore package, am gonna fix that after I merge this. Ref test fail outside this PR https://github.com/valeriupredoi/PyActiveStorage/actions/runs/7778058297/job/21228174521 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
'n'component needs to be anumpyarray with retained dimensionsCloses #173
Before you get started
Checklist