Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin s3fs >=2024.2.0 #176

Merged
merged 6 commits into from
Feb 5, 2024
Merged

Pin s3fs >=2024.2.0 #176

merged 6 commits into from
Feb 5, 2024

Conversation

valeriupredoi
Copy link
Collaborator

@valeriupredoi valeriupredoi commented Feb 5, 2024

Description

Closes #175

The problem is aiobotocore is a dependency of s3fs but it's not a clean install - since aiobotocore=2.11.2, s3fs is looking at overriding the conda install and plopping the (non-functional) PyPI wheel - versioning is wonky as well, it installs an ancient 0.10 linux64 instead of the noach modern 2+ one. Clearly an issue with the s3fs deps table, which I will attempt at fixing now, but in the meantime, this will do. Thanks to @davidhassell for inadvertently stumbling upon this 🍺

EDIT literally an hour ago s3fs fixed their deps table and released 2024.2.0 so it's a lot better and long-term to pin s3fs which is already our direct dependency than adding direct deps that are not needed 👍

Before you get started

Checklist

  • This pull request has a descriptive title and labels
  • This pull request has a minimal description (most was discussed in the issue, but a two-liner description is still desirable)
  • Any changed dependencies have been added or removed correctly (if need be)
  • All tests pass

@valeriupredoi valeriupredoi changed the title set aiobotocore as a direct dependency with a relevant pin (for now) Pin s3fs >=2024.2.0 Feb 5, 2024
Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d5a5597) 86.95% compared to head (83549c7) 86.93%.
Report is 4 commits behind head on main.

Files Patch % Lines
activestorage/active.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #176      +/-   ##
==========================================
- Coverage   86.95%   86.93%   -0.03%     
==========================================
  Files           8        8              
  Lines         621      620       -1     
==========================================
- Hits          540      539       -1     
  Misses         81       81              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@valeriupredoi valeriupredoi merged commit f5103c4 into main Feb 5, 2024
5 of 6 checks passed
@valeriupredoi valeriupredoi deleted the grab_aiobotocore_explicitly branch February 5, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

S3 tests fail (most probably because of the new aiobotocore)
1 participant