Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create storage_options and active_storage_url API #178

Closed
wants to merge 4 commits into from
Closed

Create storage_options and active_storage_url API #178

wants to merge 4 commits into from

Conversation

davidhassell
Copy link
Collaborator

Description

Create storage_options and active_storage_url API so that they are not hardwired

Closes #177

Before you get started

Checklist

  • This pull request has a descriptive title and labels
  • This pull request has a minimal description (most was discussed in the issue, but a two-liner description is still desirable)
  • Unit tests have been added (if codecov test fails)
  • Any changed dependencies have been added or removed correctly (if need be)
  • All tests pass

@davidhassell
Copy link
Collaborator Author

Hi V - only one test fails ... and a "mock" think which I'll have to pass on to you!

@valeriupredoi
Copy link
Collaborator

this is cool, cheers @davidhassell 🍺 - my plan for this is:

  • streamline and merge Get missing values and dtype without re-opening the dataset #180 first
  • off the back of the new main, open a local PR (not messing about with forks)
  • merge this in that
  • add optional logon options for anon buckets integrated via this PR, when @markgoddard enables anon buckets in Reductionist
  • plop a GH Actions test to test this and the anon bucket storage via the newly deployed Reductionist on @bnlawrence 's cloud machine
  • merge
  • then open a new PR allowing user specified config/logon options (bottom of the pile)

🍺

@valeriupredoi valeriupredoi changed the base branch from main to storage_options_local_branch February 12, 2024 15:31
@valeriupredoi
Copy link
Collaborator

bugger - time to sort out conflicts now 😮‍💨

@valeriupredoi
Copy link
Collaborator

actually - too much time wasted fixing conflicts - gonna lift and drop from here, rather

@valeriupredoi
Copy link
Collaborator

many thanks, David! Closed via #182

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create storage_options and active_storage_url API
2 participants