Integrate roto-api in Krill replacing RISwhois #1233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
partim
reviewed
Dec 5, 2024
|
|
||
| use crate::commons::api::TypedPrefix; | ||
| use crate::commons::api::{Ipv4Prefix, Ipv6Prefix, TypedPrefix}; | ||
|
|
||
| //------------ IpRange ----------------------------------------------------- |
There was a problem hiding this comment.
Would it make sense to clean up the range code in rpki-rs further and then use its types directly?
There was a problem hiding this comment.
For that there would first need to be a V4/V6 range in rpki-rs (which strikes me as a good idea). However, the Krill counterparts are used far and wide throughout the system and slightly differ implementation-wise, so I am not sure if we want to do that as part of this PR.
There was a problem hiding this comment.
Good point. I guess this goes onto the Big Cleanup pile.
partim
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the downloading and parsing of RISwhois files in Krill with the roto-api.
Requires NLnetLabs/rpki-rs#306 to work