Correctly encode a CRL with empty revokedCertificates. #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bob-beck
pushed a commit
to openbsd/src
that referenced
this pull request
Jun 11, 2024
cjeker
pushed a commit
to rpki-client/rpki-client-openbsd
that referenced
this pull request
Jun 12, 2024
DRiKE
approved these changes
Jun 12, 2024
partim
added a commit
that referenced
this pull request
Jun 21, 2024
Bug fixes * Correctly encode a CRL with empty revokedCertificates. ([#295])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the encoding of CRLs by leaving out the revokedCertificates element entirely if it is empty as required by section 5.1.2.6 of RFC 5280.
There is no test whether it is actually left out since I can’t quite think of a way to do that. I have, however, manually verified the encoding and there are now tests for both cases that check that we ourselves accept the result.