Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/1595 brackets wrap on workplace ids with whitespace #6476

Merged

Conversation

duncanc19
Copy link
Collaborator

Work done

  • Created new pipe for removing trailing whitespace
  • Added pipe to components with NMDS ID inside brackets

Note

This is a quick frontend fix which improves the user experience, it does not resolve the underlying issue of there being IDs with trailing whitespace which remains an issue to be resolved.

Tests

Does this PR include tests for the changes introduced?

  • Yes
  • No, I found it difficult to test
  • No, they are not required for this change

@duncanc19 duncanc19 force-pushed the fix/1595-brackets-wrap-on-workplace-ids-with-whitespace branch from 9e99bad to d6787ee Compare January 22, 2025 15:39
@duncanc19 duncanc19 force-pushed the fix/1595-brackets-wrap-on-workplace-ids-with-whitespace branch from d6787ee to a958a0e Compare January 23, 2025 11:59
@duncanc19 duncanc19 marked this pull request as ready for review January 27, 2025 15:24
@duncanc19 duncanc19 merged commit 07a1ab6 into main Jan 27, 2025
8 checks passed
@duncanc19 duncanc19 deleted the fix/1595-brackets-wrap-on-workplace-ids-with-whitespace branch January 27, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants