Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Multi-Closure test analysis module #2272

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

New Multi-Closure test analysis module #2272

wants to merge 26 commits into from

Conversation

comane
Copy link
Member

@comane comane commented Feb 4, 2025 •
edited
Loading

addresses #2159

The main goals of this PR are:

  • multiclosure analysis modules are reviewed and rewritten based on the new findings of the inconsistent closure tests paper.
  • All functions / helpers used for computation of bias with exp. covmat are removed
  • All functions / helpers for computation of variance are removed.

comane added 26 commits February 4, 2025 15:42
@comane
first pass for removal of unused functions
0a8f60b
@comane
.
9485457
@comane
added t0set to loader for it to be produced and used in closure checks
7f9f5ad
@comane
added typing to multiclosure loaders
be3ae6c
@comane
Renamed PCAInternalMulticlosureLoader to RegularizedMulticlosureLoader
a99743c
@comane
renamed internal_multiclosure_data_loader to multiclosure_data_loader
c427dd1
@comane
renamed internal_multiclosure_data_loader_pca to regularized_multiclo…
57f2781 
…sure_data_loader
@comane
RegularizedMulticlosureLoader inherits from MulticlosureLoader
17ea589
@comane
compute mean covmat from replicas inside the multiclosure dataset loa…
5d888f5 
…der function
@comane
avoid performing cholesky decomposition on a diagonal matrix
b304201
@comane
added diagonal entries attribute to RegularizeMulticlosureLoader to a…
0729f20 
…llow for proper regularization of covariance matrix in the full-dataset case
@comane
added new function to compute bias and apposite module for bootstrap …
917b216 
…related stuff
@comane
added mean covmat function
ddc208f
@comane
moved bootstrap functions to resp module and added todos
c0f5279
@comane
filled bootstrap module
a931668
@comane
added multiclosure_bootstrap to init file
fa49885
@comane
renamed and corrected functions in multiclosure_inconsistent_output
f9a594b
@comane
changed the report structure
27169ac
@comane
changed names in example runcard
df78dea
@comane
moved inconsistent closure test module to closure tests
deda78d
@comane
moved some of the functions from multiclosure inconsistent to multicl…
63dea4a 
…osure output
@comane
added docstrings to multiclosure
dc3de13
@comane
remove unused runcard param
08a2019
@comane
fixed docstrings and removed unused variables
7f55cde
@comane
fixed buggy behaviour for n_comp = 1
3c7cfdc
@comane
polished closure results, plots and reports from all closure estimato…
06eb011 
…rs (bias and variance) that were computed using the experimental covmat rather than the regularized PDF covmat
@comane comane changed the title [WIP] Polish Closure test module New Multi-Closure test analysis module Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
closure tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@comane