Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v16.3.22 optimized point output #3257

Conversation

AliS-Noaa
Copy link

Description

following @dkokron work on the per time step output reading the ww3_outp is optimized to read per time step binary output and create per point spectral and bull/cbull output.
Addressing #2913

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? YES
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? YES (If YES, please add a link to any PRs that are pending.)

How has this been tested?

This one was for operational branch and we ran similar runs as ops and got identical point outputs with less resources. Testing is conducted on WCOSS2 (Cactus). This will be incorporated into the dev branch soon.

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple things that caught my eye.
Looks like a dramatic reduction in walltimes and resources.

@KateFriedman-NOAA KateFriedman-NOAA self-requested a review January 25, 2025 13:17
Copy link
Member

@KateFriedman-NOAA KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good! I agree with @aerorahul comments. Will review and approve once the updated ufs-weather-model tag is available and in this PR, as well as updates to the release notes. Thanks @AliS-Noaa !

@JessicaMeixner-NOAA
Copy link
Contributor

@AliS-Noaa is testing the changes based on the review and then will push them once test finish and our successful.

Co-authored-by: Jessica Meixner <jessica.meixner@noaa.gov>
AliS-Noaa and others added 6 commits January 28, 2025 15:26
Co-authored-by: Jessica Meixner <jessica.meixner@noaa.gov>
Co-authored-by: Jessica Meixner <jessica.meixner@noaa.gov>
Co-authored-by: Jessica Meixner <jessica.meixner@noaa.gov>
Co-authored-by: Jessica Meixner <jessica.meixner@noaa.gov>
Co-authored-by: Jessica Meixner <jessica.meixner@noaa.gov>
Co-authored-by: Jessica Meixner <jessica.meixner@noaa.gov>
@AliS-Noaa
Copy link
Author

@JessicaMeixner-NOAA Thank you!

@JessicaMeixner-NOAA
Copy link
Contributor

The WW3 PR has been merged. The UFS model PR should be merged soon and a new tag GFS.v16.3.22 should be made likely tomorrow.

Copy link
Member

@KateFriedman-NOAA KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for incorporating the reviewer feedback @AliS-Noaa ! One last requested change before I approve this.

Copy link
Member

@KateFriedman-NOAA KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AliS-Noaa !

@KateFriedman-NOAA KateFriedman-NOAA merged commit 2d4024c into NOAA-EMC:release/gfs.v16.3.22 Jan 30, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
production update Processing update in production
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants