-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v16.3.22 optimized point output #3257
Release v16.3.22 optimized point output #3257
Conversation
…ource allocatio, issue NOAA-EMC#3157
…-v16.3.22-pntoutp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple things that caught my eye.
Looks like a dramatic reduction in walltimes and resources.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good! I agree with @aerorahul comments. Will review and approve once the updated ufs-weather-model tag is available and in this PR, as well as updates to the release notes. Thanks @AliS-Noaa !
@AliS-Noaa is testing the changes based on the review and then will push them once test finish and our successful. |
Co-authored-by: Jessica Meixner <jessica.meixner@noaa.gov>
Co-authored-by: Jessica Meixner <jessica.meixner@noaa.gov>
Co-authored-by: Jessica Meixner <jessica.meixner@noaa.gov>
Co-authored-by: Jessica Meixner <jessica.meixner@noaa.gov>
Co-authored-by: Jessica Meixner <jessica.meixner@noaa.gov>
Co-authored-by: Jessica Meixner <jessica.meixner@noaa.gov>
Co-authored-by: Jessica Meixner <jessica.meixner@noaa.gov>
@JessicaMeixner-NOAA Thank you! |
The WW3 PR has been merged. The UFS model PR should be merged soon and a new tag GFS.v16.3.22 should be made likely tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for incorporating the reviewer feedback @AliS-Noaa ! One last requested change before I approve this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @AliS-Noaa !
2d4024c
into
NOAA-EMC:release/gfs.v16.3.22
Description
following @dkokron work on the per time step output reading the ww3_outp is optimized to read per time step binary output and create per point spectral and bull/cbull output.
Addressing #2913
Type of change
Change characteristics
How has this been tested?
This one was for operational branch and we ran similar runs as ops and got identical point outputs with less resources. Testing is conducted on WCOSS2 (Cactus). This will be incorporated into the dev branch soon.
Checklist