Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move logical checks into if blocks #3339

Open
wants to merge 21 commits into
base: develop
Choose a base branch
from
Open

Move logical checks into if blocks #3339

wants to merge 21 commits into from
+1,494 −575

Conversation

DavidHuber-NOAA
Copy link
Contributor

@DavidHuber-NOAA DavidHuber-NOAA commented Feb 20, 2025 •
edited
Loading

Description

This moves all logical checks into if blocks.

Resolves #3307

Type of change

  • Bug fix (fixes something broken)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO

How has this been tested?

  • CI tests on Hera
  • C96C48_hybatmDA_extended test on WCOSS2

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added

github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 20, 2025
View reviewed changes
@DavidHuber-NOAA DavidHuber-NOAA changed the title Move logical operations into if blocks Move logical checks into if blocks Feb 20, 2025
@DavidHuber-NOAA
Allow relative paths when running generate_workflows.sh
d29ec6f
@DavidHuber-NOAA
Merge branch 'fix/if_blocks' of github.com:davidhuber-noaa/global-wor…
9d68203 
…kflow into fix/if_blocks

* 'fix/if_blocks' of github.com:davidhuber-noaa/global-workflow:
  Simplify build scripts
@DavidHuber-NOAA DavidHuber-NOAA marked this pull request as ready for review February 20, 2025 17:11
jiaruidong2017
jiaruidong2017 previously approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@jiaruidong2017 jiaruidong2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good for snow analysis.

@DavidHuber-NOAA
Copy link
Contributor Author

Launching CI on Hera.

@DavidHuber-NOAA DavidHuber-NOAA added the CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera label Feb 28, 2025
@emcbot emcbot added CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed and removed CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress labels Feb 28, 2025
@emcbot
Copy link

emcbot commented Feb 28, 2025

Experiment C96C48_hybatmDA FAILED on Hera in Build# 1 in
/scratch1/NCEPDEV/global/CI/3339/RUNTESTS/EXPDIR/C96C48_hybatmDA_f14b2fd8

@emcbot
Copy link

emcbot commented Feb 28, 2025

Experiment C48mx500_hybAOWCDA FAILED on Hera in Build# 1 with error logs:

/scratch1/NCEPDEV/global/CI/3339/RUNTESTS/COMROOT/C48mx500_hybAOWCDA_f14b2fd8/logs/2021032500/enkfgdas_earc_tars_01.log

Follow link here to view the contents of the above file(s): (link)

@emcbot
Copy link

emcbot commented Feb 28, 2025

Experiment C48mx500_hybAOWCDA FAILED on Hera in Build# 1 in
/scratch1/NCEPDEV/global/CI/3339/RUNTESTS/EXPDIR/C48mx500_hybAOWCDA_f14b2fd8

@emcbot
Copy link

emcbot commented Feb 28, 2025

Experiment C96C48_hybatmaerosnowDA FAILED on Hera in Build# 1 with error logs:

/scratch1/NCEPDEV/global/CI/3339/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA_f14b2fd8/logs/2021122018/enkfgdas_earc_tars_01.log

Follow link here to view the contents of the above file(s): (link)

@emcbot
Copy link

emcbot commented Feb 28, 2025

Experiment C96C48_hybatmaerosnowDA FAILED on Hera in Build# 1 in
/scratch1/NCEPDEV/global/CI/3339/RUNTESTS/EXPDIR/C96C48_hybatmaerosnowDA_f14b2fd8

@emcbot
Copy link

emcbot commented Feb 28, 2025

Experiment C96C48_ufs_hybatmDA FAILED on Hera in Build# 1 with error logs:

/scratch1/NCEPDEV/global/CI/3339/RUNTESTS/COMROOT/C96C48_ufs_hybatmDA_f14b2fd8/logs/2024022400/enkfgdas_earc_tars_01.log

Follow link here to view the contents of the above file(s): (link)

@emcbot
Copy link

emcbot commented Feb 28, 2025

Experiment C96C48_ufs_hybatmDA FAILED on Hera in Build# 1 in
/scratch1/NCEPDEV/global/CI/3339/RUNTESTS/EXPDIR/C96C48_ufs_hybatmDA_f14b2fd8

@emcbot emcbot added CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed and removed CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed labels Feb 28, 2025
@emcbot
Copy link

emcbot commented Feb 28, 2025

CI Failed on Hera in Build# 1
Built and ran in directory /scratch1/NCEPDEV/global/CI/3339


Experiment C96mx100_S2S_f14b2fd8 Completed 1 Cycles: *SUCCESS* at Fri Feb 28 16:15:21 UTC 2025
Experiment C48_ATM_f14b2fd8 Completed 1 Cycles: *SUCCESS* at Fri Feb 28 16:45:41 UTC 2025
Experiment C48mx500_hybAOWCDA_f14b2fd8 Terminated with 0
FAIL
FAIL tasks failed and 1 dead at Fri Feb 28 16:57:58 UTC 2025
Experiment C48mx500_hybAOWCDA_f14b2fd8 Terminated: *FAIL*
Error logs:
/scratch1/NCEPDEV/global/CI/3339/RUNTESTS/COMROOT/C48mx500_hybAOWCDA_f14b2fd8/logs/2021032500/enkfgdas_earc_tars_01.log
Experiment C96C48_hybatmDA_f14b2fd8 Terminated with 0
FAIL
FAIL tasks failed and 1 dead at Fri Feb 28 16:58:02 UTC 2025
Experiment C96C48_hybatmDA_f14b2fd8 Terminated: *FAIL*
Error logs:
/scratch1/NCEPDEV/global/CI/3339/RUNTESTS/COMROOT/C96C48_hybatmDA_f14b2fd8/logs/2021122100/enkfgdas_earc_tars_01.log
Experiment C96C48_hybatmaerosnowDA_f14b2fd8 Terminated with 0
FAIL
FAIL tasks failed and 1 dead at Fri Feb 28 17:04:06 UTC 2025
Experiment C96C48_hybatmaerosnowDA_f14b2fd8 Terminated: *FAIL*
Error logs:
/scratch1/NCEPDEV/global/CI/3339/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA_f14b2fd8/logs/2021122018/enkfgdas_earc_tars_01.log
Experiment C96C48_ufs_hybatmDA_f14b2fd8 Terminated with 0
FAIL
FAIL tasks failed and 1 dead at Fri Feb 28 17:59:08 UTC 2025
Experiment C96C48_ufs_hybatmDA_f14b2fd8 Terminated: *FAIL*
Error logs:
/scratch1/NCEPDEV/global/CI/3339/RUNTESTS/COMROOT/C96C48_ufs_hybatmDA_f14b2fd8/logs/2024022400/enkfgdas_earc_tars_01.log
Experiment C96_atm3DVar_f14b2fd8 Completed 3 Cycles: *SUCCESS* at Fri Feb 28 18:10:56 UTC 2025
Experiment C48_S2SW_f14b2fd8 Completed 1 Cycles: *SUCCESS* at Fri Feb 28 18:29:11 UTC 2025
Experiment C48_S2SWA_gefs_f14b2fd8 Completed 1 Cycles: *SUCCESS* at Fri Feb 28 19:00:28 UTC 2025
Experiment C48mx500_3DVarAOWCDA_f14b2fd8 Completed 2 Cycles: *SUCCESS* at Fri Feb 28 19:24:48 UTC 2025

@DavidHuber-NOAA
Copy link
Contributor Author

Fixed a bug that was imported with #3393.

@DavidHuber-NOAA DavidHuber-NOAA added CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera and removed CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed labels Feb 28, 2025
@emcbot emcbot added CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress and removed CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera labels Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KateFriedman-NOAA KateFriedman-NOAA KateFriedman-NOAA requested changes

@EdwardSafford-NOAA EdwardSafford-NOAA EdwardSafford-NOAA left review comments

@JessicaMeixner-NOAA JessicaMeixner-NOAA JessicaMeixner-NOAA left review comments

@jiaruidong2017 jiaruidong2017 jiaruidong2017 left review comments

@CatherineThomas-NOAA CatherineThomas-NOAA CatherineThomas-NOAA left review comments

@aerorahul aerorahul Awaiting requested review from aerorahul aerorahul is a code owner

@sbanihash sbanihash Awaiting requested review from sbanihash sbanihash is a code owner

@JiayiPeng-NOAA JiayiPeng-NOAA Awaiting requested review from JiayiPeng-NOAA JiayiPeng-NOAA is a code owner

@EricSinsky-NOAA EricSinsky-NOAA Awaiting requested review from EricSinsky-NOAA EricSinsky-NOAA is a code owner

@GwenChen-NOAA GwenChen-NOAA Awaiting requested review from GwenChen-NOAA GwenChen-NOAA is a code owner

@GeorgeGayno-NOAA GeorgeGayno-NOAA Awaiting requested review from GeorgeGayno-NOAA GeorgeGayno-NOAA is a code owner

@RussTreadon-NOAA RussTreadon-NOAA Awaiting requested review from RussTreadon-NOAA RussTreadon-NOAA is a code owner

@CoryMartin-NOAA CoryMartin-NOAA Awaiting requested review from CoryMartin-NOAA CoryMartin-NOAA is a code owner

@guillaumevernieres guillaumevernieres Awaiting requested review from guillaumevernieres guillaumevernieres is a code owner

@AndrewEichmann-NOAA AndrewEichmann-NOAA Awaiting requested review from AndrewEichmann-NOAA AndrewEichmann-NOAA is a code owner

@DavidNew-NOAA DavidNew-NOAA Awaiting requested review from DavidNew-NOAA DavidNew-NOAA is a code owner

@WenMeng-NOAA WenMeng-NOAA Awaiting requested review from WenMeng-NOAA WenMeng-NOAA is a code owner

@BoCui-NOAA BoCui-NOAA Awaiting requested review from BoCui-NOAA BoCui-NOAA is a code owner

@jack-woollen jack-woollen Awaiting requested review from jack-woollen jack-woollen is a code owner

@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA Awaiting requested review from TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA is a code owner

@WalterKolczynski-NOAA WalterKolczynski-NOAA Awaiting requested review from WalterKolczynski-NOAA WalterKolczynski-NOAA is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Logical checks should be in if blocks