Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling AWS CI/testing #3383

Merged
merged 1 commit into from
Feb 25, 2025
Merged

Conversation

weihuang-jedi
Copy link
Contributor

The purpose of adding this file is to enable CI testing on AWS.

In the long run, we should only have only one Jenkinsfile, but for the purpose of not disrupt our current GW CI testing on NOAA's on-prem machines, we choose to have a different Jenkinsfile (Jenkinsfile4AWS), to test on AWS, when everything workout correctly, we can merge two files together.

Add a new Jenkinsfile also give us the choice of select different test cases on AWS.

Refs #3341

Type of change

  • Bug fix (fixes something broken)
  • [x ] New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO (If YES, please add a link to any PRs that are pending.)
    • EMC verif-global
    • GDAS
    • GFS-utils
    • GSI
    • GSI-monitor
    • GSI-utils
    • UFS-utils
    • UFS-weather-model
    • wxflow

How has this been tested?

This is a new feature, which will be tested on AWS.

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

@weihuang-jedi
Copy link
Contributor Author

Terry and Walter,

Kris and I have chatted on how to enable CI testing on AWS. We feel that we should:

  1. Create a new Jenkinsfile, here Jenkinsfile4AWS as a start point. We choose to start with a different Jenkinsfile, so we won't break any existing on-prem machines CI/testing. When everything workout, we can then have a new PR to merge two files together, if need to.
  2. Duplicate Terry's CI workflow, and modify it for AWS.
  3. schedule a test and see how it goes.
  4. fix any problems along the way.

If possible, could you please give it a quick review and approval?

Thanks,

Wei

@aerorahul aerorahul merged commit de83302 into NOAA-EMC:develop Feb 25, 2025
5 checks passed
@weihuang-jedi weihuang-jedi mentioned this pull request Feb 25, 2025
20 tasks
aerorahul pushed a commit that referenced this pull request Feb 25, 2025
This is a quick fix to PR #3383, which we need a specific AWS cluster
name, not just general "AWS" in Jenkinsfile4AWS NodeName. Kris helped me
figuring out this issue.

Refs #3341
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants