Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

81 config access #110

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

aradhakrishnanGFDL
Copy link
Collaborator

@aradhakrishnanGFDL aradhakrishnanGFDL commented Feb 10, 2025

@aradhakrishnanGFDL aradhakrishnanGFDL marked this pull request as draft February 10, 2025 22:10
@aradhakrishnanGFDL
Copy link
Collaborator Author

aradhakrishnanGFDL commented Feb 18, 2025

Test instructions:

gen_intake_gfdl.py /archive/am5/am5/am5f3b1r0/c96L65_am5f3b1r0_pdclim1850F/gfdl.ncrc5-deploy-prod-openmp/pp test0211_1

catalog generated here /home/a1r/github/fork/forkCatalogBuilder-/catalogbuilder/scripts/test0211_1.json

opened data and tested a bit with /home/a1r/github/fork/forkCatalogBuilder-/catalogbuilder/scripts/getdatasets.py

Also tested this python script due to some renaming being done to config files:
gen_intake_gfdl_runner_config.py (main repo)

Updated CI tests to run the default mode with a local conda install. Suggest running a stand alone test with the catalogbuilder installed as a conda package and with the new entrypoint changes from another PR, once both PRs are merged in unless there is an easier way to test both from conda, if one has the time to do a local install.

@aradhakrishnanGFDL
Copy link
Collaborator Author

These [CI tests]

(https://github.com/aradhakrishnanGFDL/forkCatalogBuilder-/actions/runs/10269451721/workflow#L37-L45) ensure that the default option without passing the --config works. It uses this
default configuration: https://github.com/aradhakrishnanGFDL/forkCatalogBuilder-/blob/81-config-access/catalogbuilder/scripts/configs/config_default.yaml

--config also works as expected based on CI tests.

A user that does not want to use the default config has two options:

1- In their local repository, replace the config_default.yaml with what they want (e.g. add column long_name)
or
2- Simply use the --config.

For [1], this can't be used with fre-cli way of running things unless there is a feature being requested.

@aradhakrishnanGFDL aradhakrishnanGFDL self-assigned this Feb 18, 2025
@aradhakrishnanGFDL aradhakrishnanGFDL marked this pull request as ready for review February 18, 2025 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant