remove 32bit FMS libraries, allows mixed precision compilation, add C6 environment #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Necessary dependecies: |
bensonr
approved these changes
Oct 2, 2024
|
Have you tested all of these changes? I have not finished updating the CI in these repositories and need probably one more day to get the CI up and running successfully. Would you be okay waiting a day or two for CI to run on these PRs? |
|
Hi Lauren, I am able to compile and run tests with no issues, 32shield and 32shieldfull are reproducible, same for the 64bit versions. I wasn't expecting the 32bit versions to be reproducible since 32bit shield is using the 32libfms while the 32bit shieldfull is using the 64bit fms. |
laurenchilutti
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will remove the FMS 32bit libraries and adopt 64bit to accommodate the new full coupler changes, where FMS is only compiled in double precision.
This PR allows a mixed precision compilation of a 32-bit dycore with the all other components in 64-bit.
Also adding a C6 environment.