Update Benchmark branch to use NDSL v2024.09.00 #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mutually incompatible versions (NOAA-GFDL#84)
* updated generate_eta_files * remove notebook, add script * lint --------- Co-authored-by: mlee03 <Mikyung.Lee@lscamd50-d.gfdl.noaa.gov>
* Updates to allow use of python3.11 * Removed main_unit_tests.yml as it is covered by tests in containers * Updated images for unit tests with openmpi and mpich
* updated generate_eta_files * remove notebook, add script * lint * correct path * update constraints * python3 execute * Update main_unit_tests_mpich.yaml * Update main_unit_tests_mpich.yaml * update input directory * get ..s correct * lint --------- Co-authored-by: mlee03 <Mikyung.Lee@lscamd50-d.gfdl.noaa.gov>
…A-GFDL#89) * test * tet * fix test dir * test * checkout pace * rename * test * rm * remove dir * fix name * test * pyshield * test * fix trigger mistake * test * change lint version * remove push * lint --------- Co-authored-by: mlee03 <Mikyung.Lee@lscamd50-d.gfdl.noaa.gov>
…tdated pull request template (NOAA-GFDL#86) * Changed workflows to use python 3.11.7, added pytest-subtests to requirments_dev.txt * Matched package dependencies between main and develop branches * Updating constraints file * Updating Dockerfile to use 3.11-slim-bookworm base python image
* fix trigger mistake * fix spacking * update yaml files * rename lint.yaml * remove backup yaml file * simply pull request trigger * beloved lint --------- Co-authored-by: mlee03 <Mikyung.Lee@lscamd50-d.gfdl.noaa.gov>
…FDL#88) * add build script for intel oneapi and gcc compiler separately * update the python version and remove the link time optimization option for gcc
…NOAA-GFDL#92) * Removed test_eta.py, moved to NDSL/tests/grid
…FDL#99) * Updated README to include directions for generating eta files * Linting * Updated baroclinic_c2.yaml to generate zarr output
bensonr
approved these changes
Jan 2, 2025
| @@ -0,0 +1,36 @@ | |||
| #!/usr/bin/env bash | |||
|
|
|||
| # Example bash script to install Pace to run bare-metal on Gaea's c4 cluster | |||
There was a problem hiding this comment.
Is this supposed to reference c5?
There was a problem hiding this comment.
It should. I am planning on making these changes before making this PR ready for review
Comment on lines
15
to
18
| export CC=`which gcc` | ||
| export CXX=`which g++` | ||
| export MPICC=`which mpicc` | ||
| export MPICXX=`which mpicxx` |
There was a problem hiding this comment.
If these are on the cray, shouldn't they be referencing the HPE development environment wrappers of cc, ftn, and CC?
There was a problem hiding this comment.
Yes they should. I will be altering this file before making this PR ready for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Include a summary of the change and which issue is fixed. Please also include
relevant motivation and context. List any dependencies that are required for
this change.
Fixes # (issue)
If this is a hotfix to a released version, please specify it.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note
any relevant details for your test configuration (e.g. compiler, OS). Include
enough information so someone can reproduce your tests.
Checklist: