Cleanup of GRIB2 message indexing and allow for GRIB1 message to be ignored #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The indexing code has been cleaned up significantly. The index dictionary now contains offsets and sizes for all sections, for all messages. This will help for a future change to allow for in-place modification of GRIB2 metdata back into the input file -- similar to how you can edit NetCDF attributes with mode = 'a'. The new code logic allows for a simplified process for managing GRIB2 messages that contain submessages. Additionally with this commit, grib2io can now safely ignore GRIB1 messages. ECMWF GRIB files can contains GRIB1 and GRIB2 (...ugh...).
Replace with datetime.timestamp(timestamp, datetime.UTC)
Some necessary changes to the grib2io xarray backend because of changes to the index dictionary structure.
Handle getting timestamp for different Python versions.
[skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.