Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.5.0 #149

Merged
merged 133 commits into from
Feb 20, 2025
Merged

v0.5.0 #149

merged 133 commits into from
Feb 20, 2025

Conversation

martin-springer
Copy link
Collaborator

Describe your changes

Release v0.5.0

Issue ticket number and link

where pvdeg.geospatial.elevation_stochastic_downselect would return metadata row indicies which were downselected instead of named gids.

Type of change

Please delete options that are not relevant.

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • [x ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ x] This change requires a documentation update

Checklist before requesting a review

  • [ x] I have performed a self-review of my code
  • [x ] Code changes are covered by tests.
  • [x ] Code changes have been evaluated for compatibility/integration with Scenario analysis (for future PRs)
  • [ x] Code changes have been evaluated for compatibility/integration with geospatial autotemplating (for future PRs)
  • [ x] New functions added to init.py
  • [x ] API.rst is up to date, along with other sphinx docs pages
  • [ x] Example notebooks are rerun and differences in results scrutinized
  • [x ] What's new changelog has been updated in the docs

@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 42.36311% with 400 lines in your changes missing coverage. Please review.

Project coverage is 61.77%. Comparing base (4f38099) to head (17d65c4).

Files with missing lines Patch % Lines
pvdeg/pysam.py 14.07% 116 Missing ⚠️
pvdeg/utilities.py 30.61% 68 Missing ⚠️
pvdeg/scenario.py 19.27% 67 Missing ⚠️
pvdeg/weather.py 43.63% 62 Missing ⚠️
pvdeg/geospatial.py 42.55% 27 Missing ⚠️
pvdeg/store.py 31.57% 26 Missing ⚠️
pvdeg/decorators.py 43.75% 18 Missing ⚠️
pvdeg/diffusion.py 61.53% 15 Missing ⚠️
pvdeg/geospatialscenario.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #149      +/-   ##
==========================================
- Coverage   66.51%   61.77%   -4.75%     
==========================================
  Files          36       39       +3     
  Lines        3396     3950     +554     
==========================================
+ Hits         2259     2440     +181     
- Misses       1137     1510     +373     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martin-springer
Copy link
Collaborator Author

@tobin-ford - The new logo isn't included in this PR yet. Do I just need to change the one image file or are there other issues that need to be addressed?

@tobin-ford
Copy link
Collaborator

@martin-springer

Logo vector graphics are included in the docs at docs/source/_static/logo-vectors. They could be moved to the main directory?

@martin-springer
Copy link
Collaborator Author

@martin-springer

Logo vector graphics are included in the docs at docs/source/_static/logo-vectors. They could be moved to the main directory?

Got it. I'll take a look. I just noticed that the readme doesn't use them yet and wasn't sure if we included the new one somewhere

@tobin-ford
Copy link
Collaborator

tobin-ford commented Feb 18, 2025

@martin-springer
The logo is also missing on pypi. I had closed this issue during the design process but would be a nice fix. #76

@martin-springer martin-springer merged commit ae3151b into main Feb 20, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants