Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emergency Kestrel Fix #483

Merged
merged 5 commits into from
Feb 10, 2025
Merged

Emergency Kestrel Fix #483

merged 5 commits into from
Feb 10, 2025

Conversation

rajeee
Copy link
Contributor

@rajeee rajeee commented Feb 7, 2025

Fixes # .

Pull Request Description

Ideally, this should have been done in #480, but we missed it. #480 works for buildstock_local, but in HPC, the project directory cannot be referenced from the user's home directory - it needs to be copied over to the local scarth. This PR adds the necessary copying so that BSB can work in Kestrel.

Checklist

Not all may apply

  • Code changes (must work)
  • Tests exercising your feature/bug fix (check coverage report on Checks -> BuildStockBatch Tests -> Artifacts)
  • Coverage has increased or at least not decreased. Update minimum_coverage in .github/workflows/coverage.yml as necessary.
  • All other unit and integration tests passing
  • Update validation for project config yaml file changes
  • Update existing documentation
  • Run a small batch run on Kestrel to make sure it all works if you made changes that will affect Kestrel
  • Add to the changelog_dev.rst file and propose migration text in the pull request

Copy link
Contributor

@joseph-robertson joseph-robertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you've tested this now works in HPC, then I approve.

@afontani afontani merged commit 810b405 into develop Feb 10, 2025
4 checks passed
@afontani afontani deleted the no_lib2 branch February 10, 2025 16:37
@afontani afontani assigned afontani and rajeee and unassigned afontani Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants