Reproduce 2017 #20
Draft
Reproduce 2017 #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
At this point, the three steps for data downloads and preparation work with the pixi controlled environment:
|
I shall confirm that later and maybe clean it.
It was originally a static method, thus it didn't require anything from `Self`. This is in preparation to spread and clean the library.
There is no need to be part of NEI object.
Temporary solution to bypass failure when renegotiating an SSL connection. Downgraded Python to allow older cryptography library that ignores such error. This must be addressed ASAP.
The path was decoupled from the filename, thus missing a join. I don't know how it was working before.
castelao
force-pushed
the
reproduce_2017
branch
from
84dcd3e to
428fa26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reproduces the 2017 dataset with the intention to validate the code, i.e. everything is running as expected, before I can start moving parts towards the 2022 edition. Too many moving parts results in inefficient debugging.
I'm also moving some functions outside classes in preparation for refactoring. Those moved functions are preserved the best possible, and usually only the
selfcomponent is addressed. The intention is to minimize room for bugs and be sure that everything runs as expected.