-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement persistent matmul scheduling #3812
base: main
Are you sure you want to change the base?
Conversation
I think this covers the motivation for #3616
There is still one case that fails, which we should fix. I'll create an issue for it.
Co-authored-by: Ryan Spring <rspring@nvidia.com>
…ersistent_kernel_impl
!test |
Description
Changes walkthrough 📝
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
Stacked on #3642
This is a followup to #3792 that implements persistent scheduling.
There is a current limitation that affects both persistent scheduling and "grid swizzling": if
MatmulOp
orLinearOp
are present in the fusion, we will hit inlining errors. This is because in that case we have a non-trivialAxisMapping
on theMmaOp
. The missing input dimensions are not tracked through the scheduling transforms (merges and splits) required for either grid swizzling or persistent scheduling. Because of this, I introduced three new parametrized tests matching the originalMLPBenchmarkTest
s but with_BroadcastInputs
suffix. These tests usefusedMultiplySum
instead oflinear
. Thepersistent
variant of the nonBroadcastInputs
tests are skipped until we fix the inlining issue.I currently observe a correctness issue in the
MLPBenchmarkTest.FwdEpilogueFusion_BroadcastInputs
test regardless of parametrization. This means that we are getting incorrect results even for data parallel scheduling. I confirmed this test also fails on main. I currently skip this test with a warning mesage.