Fix Dask Client weirdness with fuzzy deduplication PyTests #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>
ryantwolf
approved these changes
Feb 11, 2025
Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>
|
Closing in favor of #540. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When #514 was merged, it created weirdness where some fuzzy deduplication PyTests from
test_fuzzy_dedup.pywere failing due to Dask Client crashes. When I remove the fuzzy deduplication tests fromtest_backends.py, the failures are fixed.Alternatively, I tried renaming
test_backends.pytotest_module_backends.py, so that thetest_fuzzy_dedup.pytests would run first, and that fixed them too. However, this caused the fuzzy deduplication tests intest_module_backends.pyto fail instead.