Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PyTorch] Remove MXFP8 scale-inv padding in MXFP8 all-gather #1455

Merged
merged 3 commits into from
Feb 4, 2025

Conversation

timmoon10
Copy link
Collaborator

Description

#1431 added padding to MXFP8 scale-inverses to satisfy alignment requirements in MXFP8 kernels. However, we didn't properly handle the padding in tensor-parallel all-gathers. This PR makes sure to remove padding when necessary.

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Changes

  • Remove MXFP8 scale-inv padding in MXFP8 all-gather

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Signed-off-by: Tim Moon <tmoon@nvidia.com>
@timmoon10 timmoon10 added bug Something isn't working 2.0.0 labels Feb 4, 2025
pre-commit-ci bot and others added 2 commits February 4, 2025 22:00
@timmoon10 timmoon10 merged commit 6af5ca3 into NVIDIA:release_v2.0 Feb 4, 2025
11 checks passed
@timmoon10 timmoon10 deleted the debug-tp-with-padded-mxfp8 branch February 4, 2025 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0.0 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant