Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to torch.compile for dropout for torch v>2.2 #607

Merged
merged 2 commits into from
Jan 19, 2024
Merged

Switch to torch.compile for dropout for torch v>2.2 #607

merged 2 commits into from
Jan 19, 2024

Conversation

ksivaman
Copy link
Member

Fixes #597

@ksivaman
Switch to torch.compile for dropout for torch v>2.2
7c6b929 
Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
@ksivaman ksivaman requested a review from timmoon10 January 16, 2024 15:35
@ksivaman ksivaman self-assigned this Jan 16, 2024
@ptrendx ptrendx added the 1.3.0 label Jan 17, 2024
@ksivaman
Copy link
Member Author

/te-ci pytorch

timmoon10
timmoon10 approved these changes Jan 19, 2024
View reviewed changes
Copy link
Collaborator

@timmoon10 timmoon10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ksivaman ksivaman merged commit 051db0d into NVIDIA:main Jan 19, 2024
21 checks passed
ksivaman added a commit that referenced this pull request Feb 7, 2024
@ksivaman
Switch to torch.compile for dropout for torch v>2.2 (#607)
b0af31a 
Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timmoon10 timmoon10 timmoon10 approved these changes

Assignees

@ksivaman ksivaman

Labels
1.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Performance regression of bias_dropout_add_fused_train after switching to torch.compile
3 participants
@ksivaman @timmoon10 @ptrendx