Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Fix multiple typos #613

Merged
merged 1 commit into from
Jan 19, 2024
Merged

chore: Fix multiple typos #613

merged 1 commit into from
Jan 19, 2024

Conversation

hugo-syn
Copy link
Contributor

Fix multiple typos

ptrendx
ptrendx approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@ptrendx ptrendx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@ptrendx
Copy link
Member

ptrendx commented Jan 18, 2024

Could you sign your commit? See https://github.com/NVIDIA/TransformerEngine/blob/main/CONTRIBUTING.rst#sign-your-work for details.
Since it is a single commit you can just git commit --amend --signoff and then force push to the branch.

@hugo-syn
chore: Fix multiple typos
9836e79 
Signed-off-by: hugo-syn <hugo.vincent@synacktiv.com>
@hugo-syn
Copy link
Contributor Author

@ptrendx should be better now

@ptrendx ptrendx merged commit b4b8ae7 into NVIDIA:main Jan 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptrendx ptrendx ptrendx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hugo-syn @ptrendx