Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra echoes during docker build in CI #583

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

trvachov
Copy link
Collaborator

@trvachov trvachov commented Jan 8, 2025

Description

Add some extra logging to CI's docker build.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactor
  • Documentation update
  • Other (please describe):

CI Pipeline Configuration

Configure CI behavior by checking relevant boxes below. This will automatically apply labels.

Note

By default, the notebooks validation tests are skipped unless explicitly enabled.

Usage

/build-ci

Pre-submit Checklist

  • I have tested these changes locally
  • I have updated the documentation accordingly
  • I have added/updated tests as needed
  • All existing tests pass successfully

@trvachov
Copy link
Collaborator Author

trvachov commented Jan 8, 2025

/build-ci

1 similar comment
@trvachov
Copy link
Collaborator Author

trvachov commented Jan 8, 2025

/build-ci

@trvachov trvachov changed the title ARM docker build with 24.12 pytorch fw image Add extra echoes during docker build in CI Jan 8, 2025
@trvachov trvachov force-pushed the trvachov/docker-build-echos branch from 5918b45 to ad9578f Compare January 8, 2025 19:23
@trvachov trvachov requested a review from pstjohn January 8, 2025 19:23
@trvachov
Copy link
Collaborator Author

trvachov commented Jan 8, 2025

/build-ci

@trvachov trvachov force-pushed the trvachov/docker-build-echos branch from ad9578f to 0eb977c Compare January 8, 2025 19:26
@trvachov trvachov force-pushed the trvachov/docker-build-echos branch from 0eb977c to 3b3b390 Compare January 8, 2025 19:40
Copy link
Collaborator

@jstjohn jstjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable.

@trvachov
Copy link
Collaborator Author

trvachov commented Jan 9, 2025

/build-ci

1 similar comment
@dorotat-nv
Copy link
Collaborator

/build-ci

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants