Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an example of loading a decoder .so #42

Merged
merged 22 commits into from
Jan 8, 2025

Conversation

melody-ren
Copy link
Collaborator

No description provided.

Signed-off-by: Melody Ren <melodyr@nvidia.com>
Signed-off-by: Melody Ren <melodyr@nvidia.com>
Signed-off-by: Melody Ren <melodyr@nvidia.com>
Signed-off-by: Melody Ren <melodyr@nvidia.com>
Signed-off-by: Melody Ren <melodyr@nvidia.com>
Signed-off-by: Melody Ren <melodyr@nvidia.com>
@melody-ren melody-ren marked this pull request as ready for review December 18, 2024 23:20
Signed-off-by: Melody Ren <melodyr@nvidia.com>
Signed-off-by: Melody Ren <melodyr@nvidia.com>
Signed-off-by: Melody Ren <melodyr@nvidia.com>
CMakeLists.txt Outdated Show resolved Hide resolved
Signed-off-by: Melody Ren <melodyr@nvidia.com>
Signed-off-by: Melody Ren <melodyr@nvidia.com>
Signed-off-by: Melody Ren <melodyr@nvidia.com>
Copy link
Collaborator

@bmhowe23 bmhowe23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @melody-ren. I think this looks great. Could you please add a Python test that demonstrates this working as well? I think you said it should work without any further changes?

Signed-off-by: Melody Ren <melodyr@nvidia.com>
Copy link
Collaborator

@bmhowe23 bmhowe23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. The CI timed out for what looks to be an unrelated reason, so I kicked it off to see if the failure is repeatable.

Signed-off-by: Melody Ren <melodyr@nvidia.com>
@melody-ren melody-ren merged commit 4f96465 into NVIDIA:main Jan 8, 2025
13 checks passed
justinlietz pushed a commit to justinlietz/cudaqx that referenced this pull request Jan 16, 2025
Add an example of auto loading decoder plugins

Signed-off-by: Melody Ren <melodyr@nvidia.com>
@melody-ren melody-ren deleted the plugin_example branch February 3, 2025 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants