Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vgpu-manager] update firmware search path #21

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

cdesiniotis
Copy link
Contributor

@cdesiniotis cdesiniotis commented Apr 11, 2024

No description provided.

@tariq1890
Copy link
Contributor

Let's do this is in rhel9 as well please

@cdesiniotis cdesiniotis force-pushed the vgpu-manager-fw-search-path branch from fec31da to 7fad38e Compare April 11, 2024 22:17
@cdesiniotis
Copy link
Contributor Author

Let's do this is in rhel9 as well please

We currently do not have a rhel9 directory for the vGPU Manager image.

Copy link
Collaborator

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you re-write the commit message/ PR tittle so it doesn't show as both title and message as is happening right now

This allows the nvidia kernel module to properly find the path to the GSP firmware
files that are installed in the driver container.

Signed-off-by: Christopher Desiniotis <cdesiniotis@nvidia.com>
@cdesiniotis cdesiniotis force-pushed the vgpu-manager-fw-search-path branch from 7fad38e to 8057298 Compare May 21, 2024 22:23
@cdesiniotis cdesiniotis changed the title [vgpu-manager] update firmware search path so nvidia kernel module ca… [vgpu-manager] update firmware search path May 21, 2024
@cdesiniotis
Copy link
Contributor Author

Could you re-write the commit message/ PR tittle so it doesn't show as both title and message as is happening right now

Done.

ping @shivamerla for a re-review.

@cdesiniotis cdesiniotis requested a review from shivamerla May 21, 2024 22:24
@tariq1890
Copy link
Contributor

@cdesiniotis Can this be merged?

@cdesiniotis cdesiniotis merged commit 497684d into NVIDIA:main Jun 7, 2024
6 checks passed
shivakunv pushed a commit to shivakunv/gpu-driver-container that referenced this pull request Aug 12, 2024
…path

[vgpu-manager] update firmware search path
shivakunv pushed a commit to shivakunv/gpu-driver-container that referenced this pull request Aug 13, 2024
…path

[vgpu-manager] update firmware search path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants