Add the commit SHA tag during building of precompiled image #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivakunv
commented
Feb 4, 2025
| - opened | ||
| - synchronize | ||
| branches: | ||
| - tagcommittshaimage |
shivakunv
commented
Feb 4, 2025
| @@ -37,17 +49,19 @@ jobs: | |||
| id: extract_driver_branch | |||
| run: | | |||
| # get driver_branch | |||
| DRIVER_BRANCH=("535" "550") | |||
| DRIVER_BRANCH=("535") | |||
shivakunv
commented
Feb 4, 2025
| driver_branch_json=$(printf '%s\n' "${DRIVER_BRANCH[@]}" | jq -R . | jq -cs .) | ||
| echo "driver_branch=$driver_branch_json" >> $GITHUB_OUTPUT | ||
|
|
||
| # get kernel flavors | ||
| KERNEL_FLAVORS=("aws" "azure" "generic" "nvidia" "oracle") | ||
| # KERNEL_FLAVORS=("aws" "azure" "generic" "nvidia" "oracle") | ||
| KERNEL_FLAVORS=("generic") |
shivakunv
commented
Feb 4, 2025
| kernel_flavors_json=$(printf '%s\n' "${KERNEL_FLAVORS[@]}" | jq -R . | jq -cs .) | ||
| echo "kernel_flavors=$kernel_flavors_json" >> $GITHUB_OUTPUT | ||
|
|
||
| # get ubuntu distributions | ||
| DIST=("ubuntu22.04" "ubuntu24.04") | ||
| # DIST=("ubuntu22.04" "ubuntu24.04") | ||
| DIST=("ubuntu22.04") |
shivakunv
commented
Feb 4, 2025
| @@ -90,11 +90,11 @@ pull-signed_ubuntu20.04%: DRIVER_TAG = $(DRIVER_BRANCH) | |||
|
|
|||
| pull-signed_ubuntu22.04%: DIST = ubuntu22.04 | |||
| pull-signed_ubuntu22.04%: DRIVER_TAG = $(DRIVER_BRANCH) | |||
| pull-signed_ubuntu22.04%: IMAGE_TAG = $(DRIVER_BRANCH)-$(KERNEL_VERSION)-$(DIST) | |||
| pull-signed_ubuntu22.04%: IMAGE_TAG := $(if $(VERSION),$(VERSION)-)$(DRIVER_BRANCH)-$(KERNEL_VERSION)-$(DIST) | |||
There was a problem hiding this comment.
IMAGE_TAG = does lazy initiliazation
added := to expand the variable IMAGE_TAG :=
if VERSION is non empty add VERSION- (commitsha-)
shivakunv
commented
Feb 4, 2025
| @@ -389,6 +403,7 @@ jobs: | |||
| retention-days: 15 | |||
|
|
|||
| publish-precompiled-image: | |||
| if: "!github.event.COMMIT_SHORT_SHA" | |||
There was a problem hiding this comment.
do not publish in case of dev env
shivakunv
force-pushed
the
tagcommittshaimage
branch
from
0bd4db8 to
aaefa63
Compare
Signed-off-by: shiva kumar <shivaku@nvidia.com>
shivakunv
force-pushed
the
tagcommittshaimage
branch
from
aaefa63 to
9195e64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.