-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ngc signing job for auto signing #32
Conversation
d3182c0
to
afdab90
Compare
afdab90
to
b89e870
Compare
.nvidia-ci.yml
Outdated
needs: | ||
- release:ngc-ubuntu20.04 | ||
|
||
sign:ngc-rhcos4.9: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to use a matrix so that we have one sign:ngc-rhcos
job and we specify a matrix of RHCOS_VERSIONS
(e.g. 4.9, 4.10, ...)? The same suggestion applies for the rhel jobs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may require us to also parallelize the release:ngc-rhcos
jobs using similar logic. If required we can improve this in a follow-up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added : ubuntu 22.04, 20.04 , rhcos and rhel in parallel matrix .
@cdesiniotis
b7c18a5
to
85366a1
Compare
92d9f0f
to
201e3dd
Compare
@tariq1890 @cdesiniotis @elezar I have tested some new changes to remove hardcoded value for DRIVER VERSION: summary : added setup stage to set the env
Please suggest what should be done: If you are okay with this change, I will merge these changes into the current PR. I will create a separate Jira ticket for this. I'll remove all hardcoded values and import the DRIVER_VERSION, VERSION, etc., and add them to the setup stage, which can override the current values. In this case, we will have to change only one file or import the pipeline variable from the GitHub variable. |
0f0ffc3
to
2a1cd15
Compare
added conditional run with commit tag |
Signed-off-by: shiva kumar <shivaku@nvidia.com>
2a1cd15
to
04f4c9d
Compare
moved : inside .sign:ngc as @cdesiniotis comments : |
@shivakunv I am fine with the current approach. We can always improve this in a follow-up. |
add ngc signing job for auto signing
add ngc signing job for auto signing
@cdesiniotis @elezar PTAL