Add line error checking; rename shader folder env variable; refactor ellipse #39
Conversation
Checking for OpenGL errors is now performed sporadically in the Line class. -The noexcept specifier was removed from various functions, which now can throw exceptions. -In any function where OpenGL is called, the function to check errors from utilities is called.
Shader folder environment variable renamed to MXD_SHADER_ROOT
|
I have removed TODOs related to the shader functionality since I have addressed these issues previously (I think). If the shader and program classes require further changes to be usable, please let me know. |
The ellipse class has been refactored in order to comply with the pimpl idiom and the changes observed in the line class. The names of the parameters taken have been changed in order to comply with project naming standards as well as the astronomical definition of an ellipse.
fayalalebrun
changed the title
|
I have refactored ellipse in order to follow the pimpl idiom and according to the changes to the line class. I have also changed the parameter names in order to follow project naming conventions. |
|
I've removed the geometry failing test, as there is nothing to test in this class. |
|
I modified the get_env_var() function to throw an exception if an environment variable is not found. I think this will help us more easily identify error related to this. I added a couple of tests relating to this function, including one which makes sure that SHADER_ROOT is set. |
|
I've added a method to emplace shaders directly into the program class, in order to improve the way shaders are used in the program. Also, I've added a couple of tests for program which now means that all methods in program are tested. |
|
I've added a more extensive error message in case program creation fails, in order to solve a TODO. |
Added tests to line in order to cover all methods offered by this class.
Added a part to shader test that checks if the is_compiled method returns the correct value.
The ellipse tests have been updated to ensure the testing of the set_color function.
|
I've updated the line, shader and ellipse tests in order to ensure that all methods in these classes are tested. |
I've had to remake this from #38, since I named a commit wrongly, and thus I had to force push into my master branch in order to fix it. Here are the comments that I had left until then:
Checking for OpenGL errors is now performed sporadically in the Line
class.
-The noexcept specifier was removed from various functions, which now
can throw exceptions.
-In any function where OpenGL is called, the function to check errors
from utilities is called.
I've renamed the shader folder environment variable to MXD_SHADER_ROOT, in order to avoid conflicting with environment variables which are part of other programs.
Fixes #36.
Resolves #16.