Fix check_python_import() #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The file diagnose.py has a test called check_python_import which is run during the unit testing. This function is failing with the message "'FrozenImporter' has no attribute 'get_filename'". Apparently pkgutil.get_loader() can return different types of loaders.
aaronchantrill
added
Priority: Medium
Status: Completed
Type: Bug
Priority: Low
and removed
Priority: Medium
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The file diagnose.py has a test called check_python_import which is run during the unit testing. This function is failing with the message "'FrozenImporter' has no attribute 'get_filename'".
Apparently pkgutil.get_loader() can return different types of loaders.
Related Issue
Error "'FrozenImporter' has no attribute 'get_filename'" when running unit tests #395
Motivation and Context
This fixes an issue creating false failures on unit tests.
How Has This Been Tested?
Tested on Raspberry Pi 5 and x86_64 laptop. This should not affect other areas of the code.
Types of changes
Checklist: