Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Broken Links in Readme #431

Closed
wants to merge 1 commit into from

Conversation

Akhsuna07
Copy link

Description

Fixed the Broken Link in the readme file

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@aaronchantrill aaronchantrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears that the LGTM has been subsumed into Github code scanning, and the LGTM.com website is no longer a thing, so yes, this link and image should be removed from the README.md file. It might be that it could be replaced with something else. I'm not sure. From what I'm reading, it appears that the functionality is now built into Github, but I'm not sure if that is something that has to be enabled for a particular repository.

The next link and image related to requires.io also appear to be defunct.

I'm not sure why there is an empty hyperlink around the blue python badge that precedes these two links, or what the meaning of that badge is.

Copy link
Contributor

@aaronchantrill aaronchantrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Akhsuna07 I'm inclined to accept this, but you would have to accept the contributor license agreement first.

@aaronchantrill
Copy link
Contributor

I haven't heard back from the requestor and they have not signed the CLA, so closing.

@niranjan-kurhade
Copy link

I haven't heard back from the requestor and they have not signed the CLA, so closing.

Hey @aaronchantrill, I would love to work on this issue.
What should the badge be replaced with?
Let me know.

@aaronchantrill
Copy link
Contributor

@niranjan-kurhade, thank you for offering to help. I don't think either of them would have to be replaced with anything. Just removing them would be enough.

Thank you,
Aaron

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants