-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Must focus on interactive container #126
Must focus on interactive container #126
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For non-Compose apps, it doesn't make difference as containers are properly focusing.
For Compose apps like Accrescent, it makes difference because:
a) it focus all container, not just text;
b) for bottom sheet tabs it announces now which one is chosen.
9c09ac7
to
25fe39d
Compare
…ot-focusing-on-non-clickable-container # Conflicts: # app/src/main/java/com/neo/speaktouch/utils/NodeValidator.kt
…oad repositories have not been configured.
28b4b61
to
3b2be3a
Compare
|
||
plugins { | ||
id("org.gradle.toolchains.foojay-resolver-convention") version "0.7.0" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unable to download the specified JDK.
Failed to query the value of property 'buildFlowServiceProperty'.
> Could not isolate value org.jetbrains.kotlin.gradle.plugin.statistics.BuildFlowService$Parameters_Decorated@3ccc7b25 of type BuildFlowService.Parameters
> A problem occurred configuring project ':buildSrc'.
> Failed to calculate the value of task ':buildSrc:compileJava' property 'javaCompiler'.
> No matching toolchains found for requested specification: {languageVersion=17, vendor=ADOPTIUM, implementation=vendor-specific} for LINUX on x86_64.
> No locally installed toolchains match and toolchain download repositories have not been configured.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you managed to solve it already?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this change solves it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, probably I understand now. You would like correct JDK to be downloaded while trying to build on another machine with e.g. JDK 21 installed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I realized it wasn't working properly because I took advantage of the recess to change my development setup. I installed open jdk and not temurin specifically, and then it threw an error during the build. As we specified the adoptium distro in the toolchain, even though the version was correct, since the distro was wrong, it wouldn't allow the build. But thanks to Foojay Toolchains, it should have been able to download and configure the correct distro on its own, which didn't happen.
From what I understand, since the toolchain was configured in buildSrc, Foojay Toolchains should have been too, which is why it didn't work.
Description
Read the issue #125
Improvements
Fixed issues