Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Must focus on interactive container #126

Merged

Conversation

Irineu333
Copy link
Member

@Irineu333 Irineu333 commented Dec 2, 2023

Description

Read the issue #125

Improvements

  • Focus on interactive container

Fixed issues

  • Not focusing on non-clickable container

@Irineu333 Irineu333 added the bug Something isn't working label Dec 2, 2023
@Irineu333 Irineu333 added this to the MVP milestone Dec 2, 2023
@Irineu333 Irineu333 requested a review from PatrykMis December 2, 2023 05:55
@Irineu333 Irineu333 self-assigned this Dec 2, 2023
@Irineu333 Irineu333 changed the title Must focus on interactive container [WIP] Must focus on interactive container Dec 4, 2023
@Irineu333 Irineu333 linked an issue Dec 4, 2023 that may be closed by this pull request
Copy link
Collaborator

@PatrykMis PatrykMis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For non-Compose apps, it doesn't make difference as containers are properly focusing.

For Compose apps like Accrescent, it makes difference because:
a) it focus all container, not just text;
b) for bottom sheet tabs it announces now which one is chosen.

@Irineu333 Irineu333 force-pushed the bugfix/ISSUE#125-not-focusing-on-non-clickable-container branch from 9c09ac7 to 25fe39d Compare December 5, 2023 20:32
@Irineu333 Irineu333 changed the title [WIP] Must focus on interactive container Must focus on interactive container Dec 5, 2023
@Irineu333 Irineu333 requested a review from PatrykMis December 5, 2023 21:54
@NeoA11y NeoA11y deleted a comment from coderabbitai bot Dec 24, 2023
…ot-focusing-on-non-clickable-container

# Conflicts:
#	app/src/main/java/com/neo/speaktouch/utils/NodeValidator.kt
@Irineu333 Irineu333 force-pushed the bugfix/ISSUE#125-not-focusing-on-non-clickable-container branch from 28b4b61 to 3b2be3a Compare December 26, 2023 18:01

plugins {
id("org.gradle.toolchains.foojay-resolver-convention") version "0.7.0"
}
Copy link
Member Author

@Irineu333 Irineu333 Dec 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to download the specified JDK.

Failed to query the value of property 'buildFlowServiceProperty'.
> Could not isolate value org.jetbrains.kotlin.gradle.plugin.statistics.BuildFlowService$Parameters_Decorated@3ccc7b25 of type BuildFlowService.Parameters
   > A problem occurred configuring project ':buildSrc'.
      > Failed to calculate the value of task ':buildSrc:compileJava' property 'javaCompiler'.
         > No matching toolchains found for requested specification: {languageVersion=17, vendor=ADOPTIUM, implementation=vendor-specific} for LINUX on x86_64.
            > No locally installed toolchains match and toolchain download repositories have not been configured.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you managed to solve it already?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this change solves it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, probably I understand now. You would like correct JDK to be downloaded while trying to build on another machine with e.g. JDK 21 installed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I realized it wasn't working properly because I took advantage of the recess to change my development setup. I installed open jdk and not temurin specifically, and then it threw an error during the build. As we specified the adoptium distro in the toolchain, even though the version was correct, since the distro was wrong, it wouldn't allow the build. But thanks to Foojay Toolchains, it should have been able to download and configure the correct distro on its own, which didn't happen.

From what I understand, since the toolchain was configured in buildSrc, Foojay Toolchains should have been too, which is why it didn't work.

@Irineu333 Irineu333 merged commit 23c7272 into develop Dec 26, 2023
2 checks passed
@Irineu333 Irineu333 deleted the bugfix/ISSUE#125-not-focusing-on-non-clickable-container branch December 26, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not focusing on non-clickable container
2 participants