feat(cosmoz-data-nav-pure): haunted implementation #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristinecula
force-pushed
the
feature/pure
branch
from
9047b4b to
10f4b21
Compare
I decided to have a whack at a more declarative data-nav. The result is a very reliable data-nav that does away with all of the complexity of keeping an item cache and mutable data. It relies on immutable data being passed from the component above. It keeps the maintain selection and need-data behaviour. It's missing the transition animation and the incomplete template, which I will add in a follow-up PR. This is meant to be used only with renderItem functions that render haunted views. This is not tested with polymer views and will likely cause bugs, due to polymer's use of mutable state.
cristinecula
force-pushed
the
feature/pure
branch
from
10f4b21 to
d585652
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided to have a whack at a more declarative data-nav. The result is a very reliable data-nav that does away with all of the complexity of keeping an item cache and mutable data. It relies on immutable data being passed from the component above. It keeps the maintain selection and need-data behaviour.
It's missing the transition animation and the incomplete template, which I will add in a follow-up PR.
This is meant to be used only with renderItem functions that render haunted views. This is not tested with polymer views and will likely cause bugs, due to polymer's use of mutable state.