Enable PyPI Publishing with CircleCI #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borgstrom
previously approved these changes
Sep 10, 2019
| command: | | ||
| python -m venv venv || virtualenv venv | ||
| . venv/bin/activate | ||
| python setup.py verify |
setup.py
Outdated
| description = 'verify that the git tag matches our version' | ||
|
|
||
| def run(self): | ||
| tag = os.getenv('CIRCLE_TAG') |
There was a problem hiding this comment.
nit: should we bail out with a different message if tag is None?
There was a problem hiding this comment.
Aye. This depends on the script being run on circle on a tagged branch. I can add some sanity.
|
@borgstrom - nits addressed and testing completed. Test PyPi is a bit slow to remove versions/projects that I want to re-use, but the api calls are happening. I'd expect us to have no issues publishing |
jasonbot
approved these changes
Sep 12, 2019
borgstrom
approved these changes
Sep 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#48
We would like to make
terraformpyavailable publicly on PyPi. In order to do this, I've updated our CircleCI workflow to include apublishjob.This job will be triggered when a tag like
v1.1.1is created, verifying that ourVERSIONfile matches the tagged version and publishing to: https://pypi.org/project/terraformpy/#description