-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add route lifetime from Router Advertisement #429
Conversation
Sends route lifetime to NETLINK RTA_EXPIRES Partially addresses NetworkConfiguration#428
This looks nice! Can we also extract the lifetime in if_copyrt in if-linux.c please? |
Yes, I can do that. |
Remove debug logging as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gah, and I forgot one last thing.
Before setting each rt_expires, check that the lifetime (before working out elapsed) is not ND6_INFINITE_LIFETIME.
check acquired time for routes only fetch "now" if routes available.
Something like this?
|
Exactly! We have a lot of that code, so maybe we benefit from a helper function in common.c?
then we can simply write:
Thoughts? If you like it, |
If not set to infinite, lifetime is shortened by time elapsed since acquired
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last round of changes, then I think we're good to merge!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI picked up a warning we need to address, but this is looking really good now.
@ColinMcInnes thanks for the excellent work here. |
@ColinMcInnes I used the new function to reduce more code in 7b94a2e Hopefully everything still works! |
Sends route lifetime to NETLINK RTA_EXPIRES
Partially addresses #428
Still need to send hoplimit