feat: implement portfolio batch service #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chominho96
approved these changes
Apr 5, 2024
| log.info("delete portfolio end.."); | ||
| } | ||
|
|
||
| private List<UUID> getExpiredPortfolioIds() { |
There was a problem hiding this comment.
expired_at column을 이용해서 유효기간이 지난 포트폴리오를 제거하는 쿼리를 jpa에서 한번에 짜는 방식 (deleteAllByExpiredAftter~~)도 가능할 것 같은데 id 리스트 먼저 찾도록 하신 이유가 있으실까요???
There was a problem hiding this comment.
jpa에서 deleteAllBy~ 를 사용하면 건 별로 삭제 쿼리가 날라가는 것으로 알고 있어서 deleteAllById를 사용하였는데 이것도 건 별로 삭제 쿼리가 날라가더라구요..?(방금 알았어요 😂)
jpql 직접 생성하는 것으로 변경해놓겠습니다 👍
chominho96
added a commit
that referenced
this pull request
Apr 26, 2024
* refactor: change dependency direction (#87) * chore: add auto generated qclass to .gitignore * fix: failed test by current time * refactor: apply dip for package dependency * chore: update interface name * test: modify test data * fix: test code * feat: add portfolio, portfolio stock entity (#89) * fix: fix test date time issue * feat: add portfolio, portfolio stock entity * feat: add portfolio, portfolio stock repository * refactor: refactor package structure * test: add test fixture * setting: add db configuration * fix: add @entity annotation * fix: fix portfolio stock to element collection * fix: remove portfolio id from PoltfolioStock * setting: fix db configuration * refactor: delete create method from portfolio entity * feat: implement portfolio batch service (#92) * refactor: divide client package * feat: implement portfolio batch service * test: add test code * test: update test code * chore: update delete query * refactor: refactor portfolio stock domain * feat: implement portfolio api (#93) * chore: remove unnecessary import * feat: add portfolio command service * feat: add portfolio query service * feat: add portfolio controller * docs: add portfolio controller docs * fix: remove portfolio command service * test: add test for create portfolio api * feat: add monthly/yearly dividend api * feat: add monthly/yearly dividend api * docs: add swagger docs * feat: implement dividend repository custom * test: add portfolio query service test * test: add portfolio controller test * feat: add sector-ratio service * feat: update portfolio controller * test: add test code * test: add service test code * feat: update swagger docs --------- Co-authored-by: Songyi Kim <ksl2950@o.cnu.ac.kr> * feat: implement read portfolio event (#95) * feat:wip add portfolio event * feat: add hits to portfolio * feat:wip add portfolio event * feat: add increment hits consumer * feat: add read portfolio event * feat: implement lock for portfolio hits (concurrency) * feat: set version initial value * feat: set version initial value * test: add read portfolio test * test: fix latch * test: fix concurrency test * test: remove event test from portfolio query service test * chore: add event log * chore: fix order of log --------- Co-authored-by: Songyi Kim <ksl2950@o.cnu.ac.kr> --------- Co-authored-by: Songyi Kim <52441906+songyi00@users.noreply.github.com> Co-authored-by: Songyi Kim <ksl2950@o.cnu.ac.kr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
close: #91
작업 내역
만료 기간이 지난 포트폴리오 삭제 기능 구현하였습니다 :->
변경사항
PR 특이 사항